Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [#4900] Recouple SubmissionValueVars for other forms for reusable FormDefinitions #4964

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🐛 [#4900] Recouple SubmissionValueVars for other forms for reusable FormDefinitions #4964

wants to merge 1 commit into from

Conversation

stevenbal
Copy link
Contributor

@stevenbal stevenbal commented Dec 23, 2024 •
edited
Loading

Closes #4900

Changes

  • Recouple SubmissionValueVars for other forms in case of reusable FormDefinitions

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled

  • Release management

    • I have labelled the PR as "needs-backport" accordingly

  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh

  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder

  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@stevenbal stevenbal force-pushed the issue/4900-recouple-reusable-fd-submission-value-vars branch from 0f40a4d to 7507b1c Compare December 23, 2024 09:33
@stevenbal stevenbal changed the title 🐛 [#4900] Recouple SubmissionValueVars for other forms in case of reusable FormDefinitions 🐛 [#4900] Recouple SubmissionValueVars for other forms for reusable FormDefinitions Dec 23, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.64%. Comparing base (9c6c899) to head (f702a31).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4964      +/-   ##
==========================================
+ Coverage   96.62%   96.64%   +0.02%     
==========================================
  Files         760      760              
  Lines       25837    25844       +7     
  Branches     3385     3387       +2     
==========================================
+ Hits        24964    24976      +12     
+ Misses        608      604       -4     
+ Partials      265      264       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevenbal stevenbal added the needs-backport Fix must be backported to stable release branch label Dec 23, 2024
@stevenbal stevenbal force-pushed the issue/4900-recouple-reusable-fd-submission-value-vars branch 2 times, most recently from 77429ed to 7ffcbdd Compare December 23, 2024 10:00
@stevenbal
Copy link
Contributor Author

stevenbal commented Dec 24, 2024 •
edited
Loading

I'm not sure why codecov is complaining on patch about stuff that was previously untested as well :/

EDIT: added a test anyway to fix the coverage

@stevenbal stevenbal force-pushed the issue/4900-recouple-reusable-fd-submission-value-vars branch from 7ffcbdd to f702a31 Compare December 24, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergei-maertens sergei-maertens Awaiting requested review from sergei-maertens

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
needs-backport Fix must be backported to stable release branch
Projects
None yet
Milestone
No milestone
1 participant
@stevenbal